Skip to content

Add Heart shape tool#3423

Closed
ashishmohapatra240 wants to merge 4 commits intoGraphiteEditor:masterfrom
ashishmohapatra240:feat/heart-shape-tool
Closed

Add Heart shape tool#3423
ashishmohapatra240 wants to merge 4 commits intoGraphiteEditor:masterfrom
ashishmohapatra240:feat/heart-shape-tool

Conversation

@ashishmohapatra240
Copy link
Copy Markdown
Contributor

@ashishmohapatra240 ashishmohapatra240 commented Nov 26, 2025

Partially Closes #3419

Graphite5.mp4
  • Add new_heart() method
  • Add Heart node to vector generator nodes
  • Add Heart to ShapeType enum and UI dropdown

@ashishmohapatra240
Add Heart shape tool
a78ee3c 
- Add new_heart() method
- Add Heart node to vector generator nodes
- Add Heart to ShapeType enum and UI dropdown
@TrueDoctor
Copy link
Copy Markdown
Member

TrueDoctor commented Nov 26, 2025

I feel like the shape looks a bit off, when I think of a heart, I usually picture something like this:

@ashishmohapatra240
Copy link
Copy Markdown
Contributor Author

ashishmohapatra240 commented Nov 26, 2025

Yeah, let me try to match the shape. I tried playing around with the values in core.rs and came up with this.

@Keavon
Copy link
Copy Markdown
Member

Keavon commented Nov 26, 2025

I heart can't be represented with just two anchor points, it needs an additional pair. We also would like gizmos to control the shape of the heart in several ways like the depth and separation of the top V, the angle of the bottom V, and maybe the "plumpness" of the bulb parts.

@ashishmohapatra240
Copy link
Copy Markdown
Contributor Author

ashishmohapatra240 commented Nov 26, 2025

I heart can't be represented with just two anchor points, it needs an additional pair. We also would like gizmos to control the shape of the heart in several ways like the depth and separation of the top V, the angle of the bottom V, and maybe the "plumpness" of the bulb parts.

On it, sir. 🫡

@Keavon Keavon marked this pull request as draft November 28, 2025 00:06
@TrueDoctor
Copy link
Copy Markdown
Member

TrueDoctor commented Jan 6, 2026

Are you still interested in working on this @ashishmohapatra240 ?

@ashishmohapatra240
Copy link
Copy Markdown
Contributor Author

ashishmohapatra240 commented Jan 6, 2026

Apologies, Yes I'm still interested. Updating you ASAP.

@Ayush2k02
Copy link
Copy Markdown
Contributor

Ayush2k02 commented Feb 11, 2026

are you still working on this ?

@ashishmohapatra240
Copy link
Copy Markdown
Contributor Author

ashishmohapatra240 commented Feb 11, 2026

yeah! 🤝

Ayush2k02
Ayush2k02 suggested changes Feb 11, 2026
View reviewed changes
Comment thread node-graph/libraries/vector-types/src/subpath/core.rs
head_base + perpendicular * half_shaft, // Head base top (shaft)
start + perpendicular * half_shaft, // Tail top
let manipulator_groups = vec![
ManipulatorGroup::new(bottom, Some(bottom + DVec2::new(radius * 1.2, -radius * 0.9)), Some(bottom + DVec2::new(-radius * 1.2, -radius * 0.9))),
Copy link
Copy Markdown
Contributor

@Ayush2k02 Ayush2k02 Feb 11, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you choose these values exactly, and move them to the top in constants

@Keavon Keavon force-pushed the master branch 2 times, most recently from 5bb6104 to 52d2b38 Compare March 9, 2026 23:35
@Keavon
Copy link
Copy Markdown
Member

Keavon commented Mar 10, 2026

Closing as outdated.

@Keavon Keavon closed this Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Ayush2k02 Ayush2k02 Ayush2k02 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Teardrop and Heart Shape Tools

4 participants

@ashishmohapatra240 @TrueDoctor @Keavon @Ayush2k02